fix(maestro): preserve tel and mailto links in replay export - #2463
Merged
thymikee merged 2 commits intoSep 10, 2026
Merged
Conversation
Member
|
No code findings at c543e30. The export now reuses the canonical deep-link classifier, and the regression coverage exercises tel/mailto through the exporter and built CLI. CI is green. The remaining blocker is the merge conflict with main; resolve it and rerun the affected checks before merging. |
Member
|
The conflict is resolved at b83b6a1 without changing the reviewed exporter behavior or dropping upstream help metadata. No code findings; tel/mailto coverage still exercises standalone and app-plus-link export. The iOS alert-test failure looks unrelated to this offline transform; resolve or rerun CI before merging. |
thymikee
added
the
ready-for-human
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replay exportpreservestel:andmailto:as MaestroopenLinkcommands, including standalone and app-plus-link actions:This completes the deep-link preservation accepted in #2407 using the canonical
openclassifier. Six files cover the exporter, regressions, help, user docs, and changelog.Resolved the reviewed conflict against
f4c8f3dd, preserving both changelog entries and upstream replay usage metadata. The original exporter fix is unchanged.Validation
Tested
b83b6a1d233f980eff9bf094ff374a9bf0eab040(Linux, Node 24.13.1, pnpm 11.17.0).tel:misclassification on current main (f4c8f3dd). The original 11 regression failures remain recorded at805ffb46.pnpm buildand 58 focused exporter, CLI, contract, and startup-import tests passed.pnpm test:maestro-compat: 363 passed;pnpm maestro:conformance: 62 passed.AGENT_DEVICE_VITEST_MAX_WORKERS=1 pnpm check:affected --run: all runnable checks passed, including 2,879 tests across 399 files, formatting, lint, types, layering, Fallow, and build.pnpm check:command-docs: 12 passed. Built CLI stdout, JSON,--out, help, app controls, and malformed-link refusal passed with an unreachable daemon URL.The previous head passed GitHub CI; fresh checks are pending. Export is an offline transform; Android/iOS round trips use runtime-port fixtures. Full coverage and provider integration remain GitHub-authoritative.